[Phase 2] Implement gNMI Set for atomic configuration changes #9

New Issue

Damien · 2025-12-20T15:41:51Z

Damien commented

2025-12-20 15:41:51 +00:00

Description

Implement gNMI Set operation to apply configuration changes atomically.

Tasks

Implement Set with update operations
Implement Set with replace operations
Implement Set with delete operations
Support multiple operations in single transaction
Handle errors and provide meaningful messages
Implement dry-run mode (validate without applying)

API Design

class GNMIClient:
    async def set(
        self,
        updates: list[tuple[str, dict]] = None,
        replaces: list[tuple[str, dict]] = None,
        deletes: list[str] = None
    ) -> SetResponse:
        """Apply configuration changes atomically"""
        
    async def apply_changes(
        self, 
        changes: list[PlannedChange],
        dry_run: bool = False
    ) -> ApplyResult:
        """Apply planned changes from diff engine"""

Atomic Transaction

All changes in a single Set request are applied atomically:

Either all succeed or all fail
No partial application
Rollback on error

Error Handling

try:
    result = await client.set(updates=[...])
except GNMISetError as e:
    print(f"Failed to apply: {e.path}")
    print(f"Reason: {e.message}")

Output

src/gnmi/client.py (extend)
src/gnmi/transactions.py

## Description Implement gNMI Set operation to apply configuration changes atomically. ## Tasks - [ ] Implement Set with update operations - [ ] Implement Set with replace operations - [ ] Implement Set with delete operations - [ ] Support multiple operations in single transaction - [ ] Handle errors and provide meaningful messages - [ ] Implement dry-run mode (validate without applying) ## API Design ```python class GNMIClient: async def set( self, updates: list[tuple[str, dict]] = None, replaces: list[tuple[str, dict]] = None, deletes: list[str] = None ) -> SetResponse: """Apply configuration changes atomically""" async def apply_changes( self, changes: list[PlannedChange], dry_run: bool = False ) -> ApplyResult: """Apply planned changes from diff engine""" ``` ## Atomic Transaction All changes in a single Set request are applied atomically: - Either all succeed or all fail - No partial application - Rollback on error ## Error Handling ```python try: result = await client.set(updates=[...]) except GNMISetError as e: print(f"Failed to apply: {e.path}") print(f"Reason: {e.message}") ``` ## Output - `src/gnmi/client.py` (extend) - `src/gnmi/transactions.py`

Damien added the phase-2-minimal-reconciler label 2025-12-20 15:42:07 +00:00

Damien referenced this issue

2026-01-10 13:00:18 +00:00

[Phase 4] Create Kestra workflow for fabric reconciliation (plan/apply) #10

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Damien/fabric-orchestrator#9